add ReportingDBParameters DB parameter group to data stack template #22284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshc
approved these changes
May 9, 2018
wjordan
force-pushed
the
data-reporting-parameter
branch
from
902fdbb
to
cea9fab
Compare
wjordan
force-pushed
the
data-reporting-parameter
branch
from
cea9fab
to
e028163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a CloudFormation resource for a MySQL 5.7 DB Parameter Group for our read-replica instance used for reporting queries. I've added comments to each (non-default) parameter adjusted.
Some of these parameters probably aren't strictly necessary for a reporting-DB instance, but come from our current primary instance and wouldn't hurt to include here.