Behavior editor #22307
Merged
Behavior editor #22307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
force-pushed
the
behavior-editor
branch
from
4bdb3a7
to
ac136cb
Compare
balderdash
force-pushed
the
behavior-editor
branch
from
efba007
to
2f67295
Compare
Hamms
reviewed
May 14, 2018
| func: behavior, | ||
| extraArgs: [], | ||
| }; | ||
| behavior = createBehavior(behavior, []); |
There was a problem hiding this comment.
I don't understand the purpose of this change
There was a problem hiding this comment.
Ah, I meant to use this function in the behavior getter block, I haven't added support for parameterized behaviors to these blocks yet, so this isn't needed.
Reverted for now.
| } | ||
| }, | ||
| addDefaultVar: false, | ||
| }); |
There was a problem hiding this comment.
I don't love how much manual work is required here to get this to work, particularly given how much of it is just copying stuff from procedures_defnoreturn. Can some of this be pushed into Blockly and generalized? (possibly in a separate PR)
There was a problem hiding this comment.
I added a helper in code-dot-org/blockly#107 and used it in 1a2037d, cutting out quite a lot of the extra junk here.
added 10 commits
May 16, 2018 17:40
This reverts commit dbb6553d2f4d69ba46fcc61464711fd23689f936.
balderdash
force-pushed
the
behavior-editor
branch
from
5bdfc9d
to
cd54708
Compare
added 2 commits
May 17, 2018 13:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "Behavior"-typed toolbox category that includes all the behaviors defined in your program, complete with "Create a Behavior" button:
You also get a modal behavior editor when you create/edit a behavior. For now you just get one param named
this sprite: