-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change email dialog #22309
Merged
Merged
Change email dialog #22309
Commits on May 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d9d55da - Browse repository at this point
Copy the full SHA d9d55daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5728937 - Browse repository at this point
Copy the full SHA 5728937View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c8ee9 - Browse repository at this point
Copy the full SHA 64c8ee9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7598a61 - Browse repository at this point
Copy the full SHA 7598a61View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6cb184 - Browse repository at this point
Copy the full SHA b6cb184View commit details -
Configuration menu - View commit details
-
Copy full SHA for c25c79f - Browse repository at this point
Copy the full SHA c25c79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 907957b - Browse repository at this point
Copy the full SHA 907957bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 249f179 - Browse repository at this point
Copy the full SHA 249f179View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b80087 - Browse repository at this point
Copy the full SHA 0b80087View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7da285 - Browse repository at this point
Copy the full SHA a7da285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aeb229 - Browse repository at this point
Copy the full SHA 4aeb229View commit details -
Configuration menu - View commit details
-
Copy full SHA for a73dfe9 - Browse repository at this point
Copy the full SHA a73dfe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5dbf38 - Browse repository at this point
Copy the full SHA f5dbf38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9db7f - Browse repository at this point
Copy the full SHA 2a9db7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c28d54 - Browse repository at this point
Copy the full SHA 8c28d54View commit details -
Configuration menu - View commit details
-
Copy full SHA for a16420b - Browse repository at this point
Copy the full SHA a16420bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e31b996 - Browse repository at this point
Copy the full SHA e31b996View commit details -
Configuration menu - View commit details
-
Copy full SHA for 865465e - Browse repository at this point
Copy the full SHA 865465eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a97ab50 - Browse repository at this point
Copy the full SHA a97ab50View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed93558 - Browse repository at this point
Copy the full SHA ed93558View commit details -
ChangeEmailForm calls onChange ✔ when the email field changes ✔ when the password field changes ✔ when the email opt-in field changes calls onSubmit ✔ when the enter key is pressed in the email field ✔ when the enter key is pressed in the password field ✔ when the enter key is pressed on the opt-in field ✔ but not when other keys are pressed ✔ and not when the form is disabled when disabled ✔ the email field is disabled ✔ the password field is disabled ✔ the opt-in field is disabled focusOnAnError() ✔ does nothing if there are no validation errors ✔ focuses on the email field if there is an email validation error ✔ focuses on the password field if there is a password validation error ✔ focuses on the email field if there are both email and password validation errors
Configuration menu - View commit details
-
Copy full SHA for f434008 - Browse repository at this point
Copy the full SHA f434008View commit details
Commits on May 12, 2018
-
ChangeEmailModal ✔ disables everything and shows save text when saving ✔ disables everything and shows save text when saving ✔ calls handleCancel when clicking the cancel button validation ✔ checks that email is present ✔ checks that email is valid ✔ checks that email is not the same as the current email ✔ reports email server errors ✔ checks that password is present ✔ reports password server errors ✔ disables the submit button when validation errors are present ✔ enables the submit button form passes validation changes clear server errors ✔ on email ✔ on password
Configuration menu - View commit details
-
Copy full SHA for 2f7b454 - Browse repository at this point
Copy the full SHA 2f7b454View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb28643 - Browse repository at this point
Copy the full SHA fb28643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d146da - Browse repository at this point
Copy the full SHA 4d146daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fbadeb - Browse repository at this point
Copy the full SHA 3fbadebView commit details
Commits on May 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 29ed7e6 - Browse repository at this point
Copy the full SHA 29ed7e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e1b16c - Browse repository at this point
Copy the full SHA 1e1b16cView commit details -
Configuration menu - View commit details
-
Copy full SHA for df13710 - Browse repository at this point
Copy the full SHA df13710View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd54d6f - Browse repository at this point
Copy the full SHA dd54d6fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.