Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change email dialog #22309

Merged
merged 29 commits into from
May 15, 2018
Merged

Change email dialog #22309

merged 29 commits into from
May 15, 2018

Commits on May 11, 2018

  1. Configuration menu
    Copy the full SHA
    d9d55da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5728937 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64c8ee9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7598a61 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b6cb184 View commit details
    Browse the repository at this point in the history
  6. Remove copypasta'd comment

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    c25c79f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    907957b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    249f179 View commit details
    Browse the repository at this point in the history
  9. Disable when saving

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    0b80087 View commit details
    Browse the repository at this point in the history
  10. Submit on enter key

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    a7da285 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4aeb229 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a73dfe9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f5dbf38 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2a9db7f View commit details
    Browse the repository at this point in the history
  15. Fix id collision

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    8c28d54 View commit details
    Browse the repository at this point in the history
  16. Use 'namespace' feature

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    a16420b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e31b996 View commit details
    Browse the repository at this point in the history
  18. Formatting cleanup

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    865465e View commit details
    Browse the repository at this point in the history
  19. Extract ChangeEmailForm

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    a97ab50 View commit details
    Browse the repository at this point in the history
  20. Change state format

    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    ed93558 View commit details
    Browse the repository at this point in the history
  21. Tests for ChangeEmailForm

        ChangeEmailForm
          calls onChange
            ✔ when the email field changes
            ✔ when the password field changes
            ✔ when the email opt-in field changes
          calls onSubmit
            ✔ when the enter key is pressed in the email field
            ✔ when the enter key is pressed in the password field
            ✔ when the enter key is pressed on the opt-in field
            ✔ but not when other keys are pressed
            ✔ and not when the form is disabled
          when disabled
            ✔ the email field is disabled
            ✔ the password field is disabled
            ✔ the opt-in field is disabled
          focusOnAnError()
            ✔ does nothing if there are no validation errors
            ✔ focuses on the email field if there is an email validation error
            ✔ focuses on the password field if there is a password validation error
            ✔ focuses on the email field if there are both email and password validation errors
    islemaster committed May 11, 2018
    Configuration menu
    Copy the full SHA
    f434008 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2018

  1. ChangeEmailModalTest

        ChangeEmailModal
          ✔ disables everything and shows save text when saving
          ✔ disables everything and shows save text when saving
          ✔ calls handleCancel when clicking the cancel button
          validation
            ✔ checks that email is present
            ✔ checks that email is valid
            ✔ checks that email is not the same as the current email
            ✔ reports email server errors
            ✔ checks that password is present
            ✔ reports password server errors
            ✔ disables the submit button when validation errors are present
            ✔ enables the submit button form passes validation
          changes clear server errors
            ✔ on email
            ✔ on password
    islemaster committed May 12, 2018
    Configuration menu
    Copy the full SHA
    2f7b454 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb28643 View commit details
    Browse the repository at this point in the history
  3. Deduplicate hashing logic

    islemaster committed May 12, 2018
    Configuration menu
    Copy the full SHA
    4d146da View commit details
    Browse the repository at this point in the history
  4. Fix test name

    islemaster committed May 12, 2018
    Configuration menu
    Copy the full SHA
    3fbadeb View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Fix ChangeEmailModal story

    islemaster committed May 14, 2018
    Configuration menu
    Copy the full SHA
    29ed7e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e1b16c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df13710 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd54d6f View commit details
    Browse the repository at this point in the history