Build Maze app from external repo #22314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ires Also update a few files to use new single points of entry for convenience
…-revert-21388-revert-21137-export-maze
joshlory
approved these changes
May 11, 2018
Hamms
deleted the
revert-22298-revert-21452-revert-21388-revert-21137-export-maze
branch
Hamms
added a commit
that referenced
this pull request
May 22, 2018
Since as of #22314, the transpiling is handled by Maze's own build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #22298 and requires code-dot-org/maze#7
With this PR, we are now including a built version of Maze from npm, rather than grabbing the source from github and building it ourselves. This takes advantage of the npm packaging introduced in code-dot-org/maze#7 and requires us to update a handful of require paths to reflect the new internal structure of the package.
The PR that this un-reverts was failing because yarn was caching maze based on the version and not the commit hash, and the version being cached did not include this fix.
By updating to a direct npm version style inclusion rather than a commit hash inclusion, we fix that and prevent it from happening again.