Privacy: add opt-in to regional partner contact form #22338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an email opt-in field to the form at https://studio.code.org/pd/regional_partner_contact/new
aoby
approved these changes
May 11, 2018
| def on_successful_create | ||
| EmailPreference.upsert!( | ||
| email: @contact_form.email, | ||
| opt_in: @contact_form.optin?, |
There was a problem hiding this comment.
nit: should we be consistent with one word vs. 2? I prefer 2:
opt_in: @contact_form.opt_in?
|
I chose radio buttons here when I think I was supposed to do a dropdown, but that's kind of dependent on a/b testing anyway, so I'll leave it like this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an email opt-in field to the form at https://studio.code.org/pd/regional_partner_contact/new
options
options when submit attempted
Thanks to @aoby for help on this.