Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applab: Support exporting projects that reference sound library #22362

Merged
merged 2 commits into from May 13, 2018
Merged

Applab: Support exporting projects that reference sound library #22362

merged 2 commits into from May 13, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented May 11, 2018 •
edited

  • Applab Export (for Web or Expo) didn't work properly when using our sound library (playSound("sound://default.mp3"))
    • We now scan the project for sound library references and fetch those files to include with the exported project
    • We subsequently rewrite references (e.g. sound://default.mp3 is replaced with assets/default.mp3 in the exported project)
    • NOTE: this won't work if student code is assembling sound URLs at runtime (e.g. playSound("sou" + "nd://" + "default.mp3"))
    • NOTE: our sound library has issues when playing from file: URLs. So the project (exported for web) works fine on a web server, but the playSound call is truncated when served from a file: URL.
    • Verified that library sounds now play as expected when exported to Expo on iOS
    • Updated Exporter tests to include a sound library file to exercise this code

@cpirich cpirich requested a review from islemaster May 11, 2018 21:35
islemaster
islemaster approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

islemaster
islemaster approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cpirich cpirich merged commit deeda78 into staging May 13, 2018
@cpirich cpirich deleted the allow_applab_exports_from_sound_library branch May 13, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster