Es6ify scrollbuttons #22376
Merged
Es6ify scrollbuttons #22376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radium requires elements with interactive styles (in this case, ':hover') to have a unique key set using either the ref or key prop. Unfortunately, it doesn't support callback refs (see FormidableLabs/radium#385), so since the string refs here were just updated to callback refs we need to add keys
Hamms
force-pushed
the
es6ify-scrollbuttons
branch
from
0fbbb7d
to
8b172f5
Compare
Hamms
added a commit
that referenced
this pull request
May 15, 2018
I typoed the key names in #22376, so only one of the scroll buttons was rendering when in minecraft mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix react/no-string-refs, which as a side effect required the addition of string keys to satisfy Radium