Privacy: teacher sign-up now requires email opt-in #22379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the opt-in is written to EmailPreference, and not to User, we rely on the User model to do the validation of this attribute so that the teacher sign-up UI can still show error messages for all the validation failures each time a submit is attempted. Because there might be other ways to create a User, the teacher sign-up UI's controller passes an additional parameter to the User object indicating that email preference opt-in is required.
|
Still need to add tests but wanted to share what's working so far. |
breville
commented
May 14, 2018
| @@ -12,7 +12,8 @@ class RegistrationsControllerTest < ActionController::TestCase | |||
| email: 'an@email.address', | |||
| gender: 'F', | |||
| age: '13', | |||
| user_type: 'student' | |||
| user_type: 'student', | |||
| email_preference_opt_in: 'yes' | |||
There was a problem hiding this comment.
I'm trying to work out why this is necessary given that we're not setting email_preference_opt_in_required: true at the same time.
|
Unit tests now added. Ready for review. |
aoby
approved these changes
May 14, 2018
| @@ -208,6 +208,20 @@ class User < ActiveRecord::Base | |||
|
|
|||
| after_create :associate_with_potential_pd_enrollments | |||
|
|
|||
| after_create :save_email_preference, if: -> {!email_preference_opt_in.nil?} | |||
There was a problem hiding this comment.
Prefer if: -> {email_preference_opt_in.present?}
|
|
||
| email_preference = EmailPreference.last | ||
| assert_equal "an@email.address", email_preference[:email] | ||
| assert_equal true, email_preference[:opt_in] |
There was a problem hiding this comment.
note this can just be assert email_preference[:opt_in]
|
|
||
| email_preference = EmailPreference.last | ||
| assert_equal "an@email.address", email_preference[:email] | ||
| assert_equal false, email_preference[:opt_in] |
There was a problem hiding this comment.
this can be refute email_preference[:opt_in]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the opt-in is written to EmailPreference, and not to User, we rely on the User model to do the validation of this attribute so that the teacher sign-up UI can still show error messages for all the validation failures each time a submit is attempted. Because there might be other ways to create a User, the teacher sign-up UI's controller passes an additional parameter to the User object indicating that email preference opt-in is required.
This is a followup to #22283
Huge thanks to @aoby for help on this.
on teacher sign-up
and when not filled out during submit