Use system rather than exec for calling crowdin commands
#22393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because exec replaces the existing process with the new one, it will also terminate the process once the command finishes. With the new sync process where we call the sync methods within the process rather than loading them as a separate one, exec kills the master process and ends the whole chain, forcing us to start over
balderdash
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because exec replaces the existing process with the new one, it will
also terminate the process once the command finishes. With the new sync
process where we call the sync methods within the process rather than
loading them as a separate one, exec kills the master process and ends
the whole chain, forcing us to start over