Assessments: style overview table #22407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkiruka
requested review from
caleybrock,
maddiedierker and
Erin007
and removed request for
caleybrock
Erin007
reviewed
May 14, 2018
| style: { | ||
| ...tableLayoutStyles.cell, | ||
| ...styles.questionCell, | ||
| maxWidth: styleConstants['content-width'] - (numAnswers * (ANSWER_COLUMN_WIDTH + PADDING * 2)), |
There was a problem hiding this comment.
As far as I can tell, this is the only place you use the PADDING constant. Why not set it to 20 initially so you don't have to do math?
Erin007
reviewed
May 14, 2018
| return this.getAnswerColumn(answer.multipleChoiceOption); | ||
| }); | ||
|
|
||
| const numAnswerColumns = columnLabelNames.length + 1; | ||
| console.log(numAnswerColumns); |
There was a problem hiding this comment.
nit: remove debugging statement
Erin007
reviewed
May 14, 2018
| { | ||
| name: 'Assessment multiple choice with 3 answers', | ||
| description: 'Ability to see assessment overview for the entire class', | ||
| story: () => ( |
There was a problem hiding this comment.
super tiny nit: instead of class, can we call this a section to be consistent with other references?
Erin007
approved these changes
May 14, 2018
|
@Erin007 @caleybrock Updated PR. |
| style: { | ||
| ...tableLayoutStyles.cell, | ||
| ...styles.questionCell, | ||
| maxWidth: styleConstants['content-width'] - (numAnswers * (ANSWER_COLUMN_WIDTH + PADDING)), |
There was a problem hiding this comment.
i think the maxWidth calculation could be pulled out into a function that accepts numAnswers as a parameter. that way you can give it a name and clear up this line a little 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to style the overview assessments table. The following changes were made to the table:
-Ensure consistent column width of the answer columns
-Add spacing between the icon(green check mark) and text using Flexbox
-Truncate the question text and adjust widths.
Before Implementation:
After Implementation:
Pair programmed Nkiru/Caley