Assessments: add summary text component and story #22415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
reviewed
May 15, 2018
| return ( | ||
| <div> | ||
| <div> | ||
| {`multiple choice questions overview ${numSubmissions}`} |
There was a problem hiding this comment.
nit: uppercase m
(and add to i18n)
|
@caleybrock Updated PR |
caleybrock
reviewed
May 15, 2018
| return ( | ||
| <div> | ||
| <div> | ||
| {i18n.summaryAssessmentsOverview()} {`${numStudentSubmissions} / ${totalNumStudents}`} |
There was a problem hiding this comment.
you can do this without double {}:
{i18n.summaryAssessmentsOverview() + '${numStudentSubmissions} / ${totalNumStudents}'}
There was a problem hiding this comment.
@caleybrock the string concatenation did not display the text correctly. I reverted back to the string interpolation I had before. Thoughts..
There was a problem hiding this comment.
@caleybrock Dave helped out with refactoring code. All set.
caleybrock
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a "SummaryText" component and story.
The summary text component displays the results of how many students submit an assessment. This component will be displayed above the overview assessment table.