[Migration] Create blocks table for storing shared blocks #22418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
May 15, 2018
dashboard/app/models/block.rb
Outdated
| serialized_attrs %{ | ||
| config | ||
| helperCode | ||
| } |
There was a problem hiding this comment.
what's the thinking behind making these properties and not columns?
There was a problem hiding this comment.
That's an excellent question, they're probably better off as columns.
|
Interesting! There was a previous "blocks" table at one point: https://github.com/code-dot-org/dashboard/commit/351199df7347f8f533c498bbde93611f73865422#diff-79e814ed2f56d19968709aab58c988da |
balderdash
force-pushed
the
block-pool-model
branch
from
0f0ced6
to
e1e4c24
Compare
|
@Hamms PTAL |
Hamms
approved these changes
May 18, 2018
| # level_type :string(255) | ||
| # category :text(65535) | ||
| # config :text(65535) | ||
| # helper_code :text(65535) |
There was a problem hiding this comment.
It's extra javascript to be added to the helper library to support this block. E.g. if you add a block for setTint(color), this would be the definition of that function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mini dev doc for the block pool: https://docs.google.com/document/d/1H4IS3g8iS3yxACriRfK1QWrx7CT4C6jhWZY-aCUMGK0/edit#