Add back support for named behaviors #22423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior equality broke for old behaviors, because they were often written to create a new function every time you try to add or remove them, e.g.:
It used to work because equality was just based on the name, but now we can compare functions directly. Because equality is broken, you can add the same behavior multiple times and you can never remove a behavior.
(Some old behaviors still work because they declared the function once and just returned it over and over, but most weren't written that way).
This PR brings back name-based comparisons.
I tried writing tests, but the
name
property on functions is readonly outside of JSInterpreter, so I just had to verify manually. That behavior broke a couple tests as well.