Add JotForm API client, translation, and question helper classes. #22474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalshah
approved these changes
May 17, 2018
| @@ -0,0 +1,61 @@ | |||
| module Pd | |||
| module JotForm | |||
| class MatrixQuestion < QuestionWithOptions | |||
There was a problem hiding this comment.
Can you give an example of a matrix question in a comment here?
|
|
||
| # Hash includes other, in form {'0' => value1, '1' => value2, ..., 'other' => otherText}. | ||
| # Note "other" can be chosen and blank, in which case we use the other text from the question. | ||
| values_with_other = answer.map {|k, v| k == 'other' ? v.presence || other_text : v} |
There was a problem hiding this comment.
Is 'other' provided by jotform? Suggest making it a const up top
There was a problem hiding this comment.
Yes, it is provided by JotForm, and it seems to be hardcoded, independent of the otherText which is the placeholder we can set. I'll add a const
| options: %w(From To), | ||
| values: [1, 2, 3] | ||
| ), | ||
| MatrixQuestion.new( |
There was a problem hiding this comment.
I'd prefer this to look like the actual matrix questions - with the text
"I feel..."
and name "like this course is good", "like I learned a lot"...
…none, referenced as parent in the sub questions.
clareconstantine
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a self-contained set of classes in
dashboard/libto interact with JotForm's API, parse questions and submissions, serialize to/from a question format we can store in the DB (as JSON) and use to process answers.The JotForm answer data alone is insufficient until it's combined with the question data.
There is a bit of complexity with, and differences between, the various types of questions we want to support and how JotForm describes them, so I have created a
Questionclass hierarchy that should make that easier to reason about and test. There are a number of extraneous fields in the JotForm question data that we don't need (formatting, redundant with other fields, etc) that are ignored and not mentioned in this PR. This also should help simplify things.This will be used for workshop daily surveys and their facilitator-specific questions in a set of forthcoming additional PRs, and it's also flexible enough to be used in future JotForm-based forms with minimal additional code.