New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include shared blocks in appOptions.level #22476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
changed the title
Include shared blocks in appOptions.level`
Include shared blocks in appOptions.level
May 17, 2018
balderdash
force-pushed
the
block-pool-model
branch
from
May 18, 2018 01:05
0f0ced6
to
e1e4c24
Compare
balderdash
force-pushed
the
block-pool-piping
branch
2 times, most recently
from
May 18, 2018 06:51
9c8cea7
to
ced19b3
Compare
balderdash
force-pushed
the
block-pool-piping
branch
from
May 18, 2018 23:59
440ecb9
to
04b3219
Compare
joshlory
approved these changes
May 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. What is the plan to test this feature?
I'll add some unit tests in a followup PR to check that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass block pool blocks to the client as
appOptions.level.sharedBlocks
. These blocks include a bit more information than the existing custom blocks, structured as so:The custom block config is the same as the existing level-specific custom block config, documented here.
After installing the blocks, append them to the specified categories unless
level.hideCustomBlocks
is set.