Increase row count limits for rollup tables #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases limit that raises exception when creating tables used for analysis of multiple choice questions and survey responses by an order of magnitude. These limits were put in place in January 2017 and were outgrown in ~1.5 years, so making limit much larger to avoid similar issues in the future.
Confirmed via querying production data that current sizes are (or would be if the exception hadn't been raised):
contained_levels: 1412 (raised exception)contained_level_answers: 7419level_sources_multi_types: 6854Also improved error message to include the size of the table that is causing an exception.