Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scoop pegasus strings to all locales (-tanya) #22518

Merged
merged 1 commit into from
May 18, 2018
Merged

scoop pegasus strings to all locales (-tanya) #22518

merged 1 commit into from
May 18, 2018

Conversation

tanyaparker
Copy link
Contributor

No description provided.

@breville
Copy link
Member

cc @Hamms

Hamms
Hamms approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little odd that only some languages got the csd1-2018_name strings added and not all, but generally LGTM!

@tanyaparker
Copy link
Contributor Author

@Hamms That's true that looks a little funny. It looks like the other files had those strings added back in your PR from ~3 days ago. I wonder if it's because the sync-pegasus script runs blindly for all the locale files that already exist in the cache directory but your script is smarter to only run for our active languages. It might be that we haven't done cleanup in the cache directory of old locale files we no longer support.

@tanyaparker tanyaparker merged commit f3e8587 into production May 18, 2018
@tanyaparker tanyaparker deleted the hotfix-privacy-strings branch May 18, 2018 18:16
tanyaparker added a commit that referenced this pull request May 18, 2018
@tanyaparker
Merge pull request #22521 from code-dot-org/production
0087c5d 
Merge back hotfix of privacy strings from #22518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

@joshlory joshlory Awaiting requested review from joshlory

@breville breville Awaiting requested review from breville

@jeremydstone jeremydstone Awaiting requested review from jeremydstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanyaparker @breville @Hamms @deploy-code-org