Give fixed ages to FactoryBot-generated users #22552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
force-pushed
the
factorybot-default-user-age
branch
from
0e1b2f2
to
6f57948
Compare
This was referenced May 21, 2018
aoby
approved these changes
May 21, 2018
| @@ -48,7 +48,7 @@ | |||
| end | |||
|
|
|||
| factory :user do | |||
| birthday Date.new(1991, 3, 14) | |||
| birthday Time.zone.today - 21.years | |||
There was a problem hiding this comment.
Note, this will fix the date when factories.rb is loaded since it's not a dynamic attribute. I think that's fine, and probably better since we create a lot of test users and while minimal there's no point recalculating today - 21.years each time. Test runs don't last days. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #22471 (comment)
Our tests are more likely to care about the age of a user than their birthdate, providing relative birthdates in our user fixtures makes more sense.