Feedback Tab Student-Facing UI #22628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 22, 2018 16:16
islemaster
approved these changes
May 29, 2018
|
|
||
| class StudentFeedback extends Component { | ||
| static propTypes = { | ||
| viewAs: PropTypes.oneOf(['Teacher', 'Student']), |
There was a problem hiding this comment.
PropTypes.oneOf(Object.keys(ViewType))
| } | ||
| {this.props.viewAs === ViewType.Student && | ||
| <StudentFeedback | ||
| ref="commentTab" |
There was a problem hiding this comment.
FYI this is a deprecated ref style. No need to fix in this PR but maybe in a followup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a feature to add a tab with a feedback box to the studio instructions.
Axosoft: https://codeorg.axosoft.com/viewitem?id=1461&type=features&force_use_number=true
For the May 11th deadline, a tab with 'coming soon' text was added for training. This is behind the 2018-teacher-experience flag.
For the June 4th deadline, behind the 'devCommentBoxTab', we are adding the follow features for students (using temporary text):
*display feedback comment, date, and teacher
This PR includes tests.
This PR builds on:
#22568
Upcoming PRs will include:
*Backend to the save and display comments.
*Only display feedback tab for students when a teacher has provided feedback.
Picture:
