Remove hotfix that didn't successfully fix anything #22637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change we attempted in #22632 that was supposed to surface a dashboard API on the pegasus domain was not effective, because we made the change in PegasusSites middleware which only applies in local development. This tears that change back out because we won't need it for the full fix (although it wasn't really hurting anything, either).
Erin007
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change we attempted in #22632 that was supposed to surface a dashboard API on the pegasus domain was not effective, because we made the change in PegasusSites middleware which only applies in local development. This tears that change back out because we won't need it for the full fix (although it wasn't really hurting anything, either).