Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enables logic for showing the gdpr dialog #22641

Merged
merged 1 commit into from May 24, 2018
Merged

Re-enables logic for showing the gdpr dialog #22641

merged 1 commit into from May 24, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented May 24, 2018

Follow up to hotfix #22636, should be merged with #22638.

@Erin007 Erin007 requested a review from islemaster May 24, 2018 00:29
islemaster
islemaster approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome. Go ahead and merge this before Circle, we'll follow up with my API move.

@Erin007 Erin007 merged commit 0ee003c into staging May 24, 2018
@Erin007 Erin007 deleted the restore-logic-for-showing-dialog branch May 24, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erin007 @islemaster