Translations of privacy strings in pegasus, apps, and dashboard #22648
Conversation
|
@Hamms I hope this doesn't conflict with your syncs. Also, do you have a recommendation for how to add these translations to crowdin before your next sync (so they don't get overwritten?) I was going to upload all the files manually via the Crowdin UI but wondering if you have an easier way with your scripts. |
|
Hmm, it might. Lemme merge the latest sync, and if GH doesn't have a conflict then I think we're good! |
|
No problem. I think it'll be easy to fix anyway. I'm on it! |
|
Looks like it does; how difficult will it be to re-apply these changes to staging latest? Re; uploading translations, the crowdin CLI has an provided you've set up credentials as outlined here Although I'm not sure what that will do for new translations we've received since the last sync; I suspect doing an upload either with the command or manually has the chance to loose use some work unless we do it right after a sync |
|
@Hamms Ok, I'll try that! Yes, I think uploading the professional translations will "overwrite" over volunteer translations. I think the volunteer translations would still exist, but the professional translations would take precedence because they're newer. But while I was doing this there wasn't much already translated, since the strings have only been in Crowdin a few days. I think it's ok. I'll be looking closely at your next sync to make sure we didn't lose any professional translations. Merge conflict resolved. Ready for your thumbs up, Elijah. :) |
apps/i18n/common/ko_kr.json
Outdated
| "gdprDialogDetails": "귀하의 본 사이트 사용에 따른 데이터는 미국으로 전송되어 보관 또는 처리될 수 있습니다.", | ||
| "gdprDialogSeePrivacyPolicy": "(상세한 내용은 당사의 개인 정보 보호 정책을 참조하십시오.)", | ||
| "gdprDialogLogout": "로그 아웃", | ||
| "gdprDialogYes": "네", |
There was a problem hiding this comment.
Here's one that was already translated. According to google translate it looks like a Yes/Yeah. I'll revert and take the existing volunteer translation.
| homepage_below_hero_announcement_text: Мы соблюдаем вашу конфиденциальность и | ||
| вносим некоторые обновления в нашу политику конфиденциальности, которые вступают | ||
| в силу с 25 мая. | ||
| homepage_below_hero_announcement_link_text: Подробнее |
There was a problem hiding this comment.
Second instance where the string was already translated. Professional translations is briefer (better for buttons) and according to Google Translate says "Learn More" while the volunteer translation is more like "to learn more." Will take the professional translation.
| homepage_below_hero_announcement_link_text: 繼續學習 | ||
| homepage_below_hero_announcement_text: 我們尊重您的隱私權，並且正在對我們的隱私權政策做一些更新 | ||
| 更新後的政策將於 5 月 25 日生效。 | ||
| homepage_below_hero_announcement_link_text: 瞭解更多資訊 |
There was a problem hiding this comment.
Third instance. Volunteer translation is more like "continue studying" while professional translation is "learn more." Keeping professional translation.
|
There were 3 strings that already had a volunteer translation. For the Korean string, I kept the volunteer translation that said "Yes" instead of the professional translation "Yeah." The other two I kept the professional translation which seemed more accurate/terse. |
|
Oh, to clarify I'm actually worried about all the other strings. I believe the upload is an all-or-nothing thing, so any strings anywhere else in our system that have been updated will be overwritten with whatever value is currently in the i18n files. |
No description provided.