Opt Out Petition Emails Under 16 #22671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
May 24, 2018
| email: petition[:email], | ||
| opt_in: false, | ||
| source: EmailPreferenceHelper::AUTOMATED_OPT_OUT_UNDER_16, | ||
| ip_address: '127.0.0.1', |
There was a problem hiding this comment.
Can we use the IP address recorded when the form was saved?
There was a problem hiding this comment.
We're the ones making the decision to opt them out, so it seems more accurate to log "our" IP address?
There was a problem hiding this comment.
Oh, good point. Should we make that a constant indicating that case, and maybe even put it into EmailPreference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set EmailPreference.opt_in to
falsefor email addresses submitted via Petition by people who were younger than 16 to comply with GDPR.