Fix and test user purge for dashboard.email_preference #22681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts_users From [spec](https://docs.google.com/spreadsheets/d/1RybuZunt5F6zSXp33oC4KdaBl20VMHVi0yprI8P30y0/edit#gid=670705846) (requires login). Expected behavior: Associations between purged users and districts (as members or as contacts) are destroyed.
From [spec](https://docs.google.com/spreadsheets/d/1RybuZunt5F6zSXp33oC4KdaBl20VMHVi0yprI8P30y0/edit#gid=670705846) (requires login). Expected behavior: All EmailPreference rows associated with a purged user's email address are also deleted.
sureshc
reviewed
May 25, 2018
| # Removes EmailPreference records associated with this email address. | ||
| # @param [String] email An email address | ||
| def remove_email_preferences(email) | ||
| EmailPreference.where(email: email).each(&:destroy) |
There was a problem hiding this comment.
EmailPreference has a unique constraint on email so maybe use find_by(email: email)?
There was a problem hiding this comment.
I assume the email being passed as an argument by the caller came from the User model and has already been stripped and lower-cased?
There was a problem hiding this comment.
Hmm, good question. I'll have to investigate. I know we strip and downcase before we hash emails, but we might store the original formatting for display back to the user.
There was a problem hiding this comment.
Looks like User model strips and downcases before save:
code-dot-org/dashboard/app/models/user.rb
Lines 544 to 562 in 12f8a84
sureshc
approved these changes
May 25, 2018
islemaster
changed the title
islemaster
changed the base branch from
account-purge-dashboard-districts
to
staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and test user purge for dashboard.email_preference
From spec (requires login).
Expected behavior: All EmailPreference rows associated with a purged user's email address are also deleted.