Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting changes due to renaming of CSP and CSD #22745

Merged
merged 2 commits into from May 30, 2018

Conversation

bencodeorg
Copy link
Contributor

@bencodeorg bencodeorg commented May 30, 2018

The versions of CSP and CSD taught in 2017-18 were renamed csp-2017 and csd-2017, and new versions of the courses for next year were created as csp-2018 and csd-2018. This PR:

  1. Creates a redshift-specific table called course_names that rolls up the two versions of the course into one.
  2. Fixes issues introduced by this change by using course_names to apply a meta naming of courses across their various versions.

@bencodeorg
Copy link
Contributor Author

@davidsbailey just FYI, should be good to go on course renaming/reporting.

@bencodeorg bencodeorg merged commit da65975 into staging May 30, 2018
@davidsbailey
Copy link
Member

These changes look good! I'm not sure how important these are to fix, but here a few other places I am still seeing 'csp' in redshift code:

or se.script_id in (select script_id from analysis.course_structure where course_name in ('csp','csd'))

where se.user_id in (select user_id from analysis.csp_csd_started_teachers where course_name = 'csp')

case when cc.course_name = 'csp' then 'CS Principles'

@bencodeorg
Copy link
Contributor Author

Thanks for looking Dave -- those are all references to the 'csp' in the course_name_short column of the new analysis.course_names table instead of the name in courses that have the year suffixes on them, so I think we're good to go.

@bencodeorg
Copy link
Contributor Author

I wouldn't be shocked if I missed something though so thanks for keeping an eye out!

@bencodeorg bencodeorg deleted the csp_csd_rename_redshift branch June 8, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants