Experiments: Prevent user enabling to the same experiment multiple times #22763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
approved these changes
May 30, 2018
|
cc others using this experiment: @davidsbailey @epeach @Erin007 @madelynkasula |
davidsbailey
approved these changes
May 30, 2018
| if Experiment.enabled?(experiment_name: experiment_name, user: current_user) | ||
| redirect_to '/', flash: {alert: "Already enabled in experiment '#{params[:experiment_name]}'."} | ||
| return | ||
| end |
There was a problem hiding this comment.
to be resilient to any existing bad data, you could also use .where(...).destroy_all instead of .find_by(...).destroy below
There was a problem hiding this comment.
Great suggestion - will follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed like I couldn't disable my experiment on production, but in reality I had enabled it multiple times (creating multiples rows in the experiments table), so even if I disabled one, there were still more.
This PR prevents that.