Disable failing reset student picture test temporarily #22801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
approved these changes
May 31, 2018
islemaster
reviewed
May 31, 2018
| end | ||
| # TODO: (madelynkasula) fix and re-enable | ||
| # test 'teacher can reset secret picture and words for their student' do | ||
| # sign_in @teacher |
There was a problem hiding this comment.
I think you can just call
skip "(madelynkasula) fix and re-enable"at the top of your test instead of commenting the whole thing out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling this test temporarily. I think the problem is that
generate_random_picturecan sometimes return the same picture (it doesn't double-check that it's not returning the current user'ssecret_picture), so this test is flaky. Going to disable and put up a PR for a permanent fix.