Move assessments out of api_controller #22816
Conversation
| @@ -95,6 +95,15 @@ module OPS | |||
| end | |||
| end | |||
|
|
|||
| # Used in react assessments tab | |||
There was a problem hiding this comment.
I'd love feedback about these routes changes in particular. This works, but I haven't written a lot of this code so I'm not sure if this is a reasonable way to go about things.
There was a problem hiding this comment.
This looks great :)
Granted if it's only used in one place it doesn't need to be specified in a concern, though also there's no harm, just an extra level of indirection. Presumably we'll want to expose this in /api/v1 as well, at which point the concern will be handy?
| section = Section.find(params[:section_id]) | ||
| authorize! :read, section | ||
| section | ||
| end |
There was a problem hiding this comment.
When it comes time to refactor, this looks like a perfect candidate for CanCan's load_and_authorize_resource
| @@ -95,6 +95,15 @@ module OPS | |||
| end | |||
| end | |||
|
|
|||
| # Used in react assessments tab | |||
There was a problem hiding this comment.
This looks great :)
Granted if it's only used in one place it doesn't need to be specified in a concern, though also there's no harm, just an extra level of indirection. Presumably we'll want to expose this in /api/v1 as well, at which point the concern will be handy?
| class Api::V1::AssessmentsController < Api::V1::JsonApiController | ||
| include LevelsHelper | ||
|
|
||
| # For each assessment in a script, return an object of script_level IDs to question data. |
There was a problem hiding this comment.
these are great comments! 👍
What's in this PR?
Going for incremental improvements on the assessments APIs after getting some good feedback in this PR: #22772
This one moves the methods out of
api_controllerinto a newassessments_controllerand creates a resource for assessments. I've updated the front end with the necessary changes. These changes were suggested here: #22772 (comment)I've also updated the comments for both of these methods as suggestion here: #22772 (comment)
What's not in this PR?
I didn't change any of the actual method code at all (I know there are lots of improvements to make here, but this PR is just organizational).
What's next?
Move the bulk of the logic in these methods to a model (maybe
level_source) or just in a separate module inliband add tests for it.