Homepages: remove privacy announcements #22863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
commented
Jun 3, 2018
| * @param {object} override - An optional override announcement. | ||
| * @return {object} An announcement to display. | ||
| */ | ||
| function getTeacherAnnouncement(override) { |
There was a problem hiding this comment.
I'm sure there's a better way to scope this function. @islemaster or @joshlory, thoughts?
There was a problem hiding this comment.
I'm not sure what you mean here. Since this goes through our Webpack pipeline, this function is currently private to this file, which seems appropriately scoped to me.
There was a problem hiding this comment.
Oh, that's good to know. Thanks.
Erin007
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the privacy announcements from signed-in teacher homepage and the signed-out homepage.
Also cleans up the signed-in teacher homepage announcement code. It no longer supports an array of announcements.
This is a followup to #22430.
Homepage is back to this: