Add .valid? checks for section course and script #22935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jun 6, 2018
| section.reload | ||
| assert_response :success | ||
| assert_nil section.course_id | ||
| refute_equal 1, section.course_id |
There was a problem hiding this comment.
redundant check after asserting nil? here and below
There was a problem hiding this comment.
haha good point. i'll update 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is follow-up for #22902 and adds checks upon updating sections to determine whether or not the provided course/script ids are valid.
Note: this code is going to be heavily refactored in upcoming PRs, so this is all temporary.