Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up feedback-tab tests #22945

Merged
merged 1 commit into from Jun 7, 2018
Merged

Speed up feedback-tab tests #22945

merged 1 commit into from Jun 7, 2018

Conversation

epeach
Copy link

@epeach epeach commented Jun 6, 2018

Combining scenarios in the feedback_tab.feature to minimize the number of times the expensive background is run.

Old Test Run: ~14 minutes
New Test Run: ~7 minutes

@epeach epeach requested a review from Hamms June 6, 2018 22:46
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 50% speedup! 🎉

@joshlory
Copy link
Contributor

joshlory commented Jun 7, 2018

Is there a way to make the expensive setup steps faster?

@epeach
Copy link
Author

epeach commented Jun 7, 2018

That's a good question! We're definitely limited by the fact that the background for these tests is a bit complicated (student has to be in a teacher section and submit 'work'). But the background is common for all the tests, so we do lose time in re-running the shared background. For test organization, I'm hesitant to combine the scenarios any further then they already are, although if this test continues to bloat run-time, that is a possibility. I spent some time trying to get a shared background to run once before all tests, but figured I'd get a fast band-aid fix out on this as soon as possible. I'm hoping to continue to look into how to run the background just once. And eventually, when this is out of development, one of these scenarios will be removed, resulting in additional speed up.

@epeach epeach merged commit 914d199 into staging Jun 7, 2018
@epeach epeach deleted the feedback-tab-test-speed-up branch June 27, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants