Revert "Revert "Update PATCH /sections/:id in dashboard, deprecate pegasus endpoint"" #22951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
commented
Jun 7, 2018
| # This endpoint needs to satisfy two endpoint formats for getting script_id | ||
| # This should be updated soon to always expect params[:script_id] | ||
| script_id = params[:script][:id] if params[:script] | ||
| script_id ||= params[:script_id] |
There was a problem hiding this comment.
new - fixes bug where one consumer provides params[:script_id] and the other provides params[:script][:id]
maddiedierker
commented
Jun 7, 2018
| assert_response :success | ||
| section.reload | ||
| assert_equal(@script_in_course.id, section.script_id) | ||
| end |
There was a problem hiding this comment.
new - tests case where one consumer provides params[:script_id] and the other provides params[:script][:id]
islemaster
approved these changes
Jun 7, 2018
maddiedierker
deleted the
revert-22949-revert-22902-update-sections-dashboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #22949
The original PR (#22902) that updated
PATCH /sections/:idwent out with yesterday's deploy with a bug, so Dave did a late deploy to help me revert the original PR. This PR reverts that revert and fixes the bug!I added "new" comments to the new parts so you can see the changes that differ from the original PR.
Background
PATCH /sections/:idexpected to receiveparams[:script_id], which is what the previous consumer supplied, but the new consumer (teacherSectionsRedux) currently (but not for long...) suppliesparams[:script][:id], which meant scripts could not be updated.I added a unit test to catch this case, and will push a follow-up PR with a feature test to cover updating sections as well (once #22955 has been merged, which adds similar feature test coverage)