New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTL (Test > Levelbuilder): 771ffbdd #22994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level thumbnail
DTT (Staging > Test) [robo-dtt]
In particular, don't capture the education|-nocookie group so that we can still extract the ID successfully.
This extracts some minimal logic from #22865 to redirect ar.code.org to an external site. By removing it from the list of partner sites, the subdomain will be removed from the CloudFront distribution. Before deploying, I will update the DNS entry for ar.code.org to send requests directly to our load balancer instead of CloudFront. Then the redirect provided via chef to varnish will operate successfully after this change is deployed to production.
…g the JotForm API in some cases (confusingly depending on other params), but integer works fine [ci skip]
Remove to_s conversion because empirically string min ids are breakin…
DTT (Staging > Test) [robo-dtt]
Video: use youtube-nocookie.com for embedded videos
DTT (Staging > Test) [robo-dtt]
Conflicts: pegasus/sites.v3/ar.code.org/views/hocvideo.haml
…-powerschool-text-changes Revert "Revert "Change text for Powerschool connect""
Pegasus: redirect ar.code.org to external site
add 2-day subjects and rename academic year subjects for consistency
remove the closed change.org campaign link and add a section for intl…
Revert "Video: use youtube-nocookie.com for embedded videos"
The `first sprite touched` and `second sprite touched` blocks weren't working because we don't currently pass both sprites into the collision event. Tested with the library in Game Lab.
DTT (Staging > Test) [robo-dtt]
…ferings Import Virginia state course offerings
Pass both sprites into collision events
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.