Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add family_name and version_year to courses #23006

Merged
merged 12 commits into from
Jun 11, 2018
Merged

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jun 11, 2018

This PR accomplishes a few cleanup steps related to course versioning:

  1. adds family_name and version_year fields as course properties
  2. reads new field values explicitly rather than inferring them from the course name
  3. starts using family_name explicitly when selecting courses from the db
  4. adds a new test for /courses/csd --> csd-2018 redirection logic, but doesn't change that logic to use db values yet. that work will likely involve adding a new "course family cache"

Copy link
Contributor

@balderdash balderdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@davidsbailey
Copy link
Member Author

Excellent, thanks for the ongoing reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants