Progress summary view: Lesson name tooltips #23020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
changed the title
caleybrock
reviewed
Jun 11, 2018
| @@ -33,6 +33,7 @@ describe('VirtualizedSummaryView', () => { | |||
| stages: [ | |||
| { | |||
| id: 456, | |||
| position: 1, | |||
There was a problem hiding this comment.
Is this already in the data we have, just not in tests?
caleybrock
reviewed
Jun 11, 2018
| )); | ||
| } | ||
|
|
||
| afterScroll = () => setTimeout(ReactTooltip.rebuild, 0); |
There was a problem hiding this comment.
It'd be nice to have a comment here explaining why this is needed.
caleybrock
approved these changes
Jun 11, 2018
caleybrock
reviewed
Jun 11, 2018
| /> | ||
| <ProgressLegend | ||
| excludeCsfColumn={scriptData.excludeCsfColumnInLegend} | ||
| /> | ||
| </div> | ||
| } | ||
| </div> | ||
| {this.renderTooltips()} |
There was a problem hiding this comment.
I'm not sure this will be better, but we already have levelDataInitialized in the render function, so you could have
{`levelDataInitialized` && this.renderTooltips()}
instead of just checking on script data like you did on line 93.
caleybrock
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair: @Erin007
In the summary view and the detail view, the numeric lesson headers now have tooltips that give the lesson names.