Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessments Tab: Surveys multiple choice overview table #23172

Merged
merged 4 commits into from Jun 19, 2018
Merged

Conversation

caleybrock
Copy link
Contributor

@caleybrock caleybrock commented Jun 19, 2018

User impact

None without experiment flag: assessmentsTab

Screenshot

screen shot 2018-06-18 at 8 24 43 pm

Summary

Summarized multiple choice results for surveys. The data was already in redux, and the table already built, so this PR is mostly just a selector function to hook up the data. I've also added tests for the redux selector.

There are still TODOs in this code. The goal is to get to a point where we can play around with the tables all hooked up and then go back and polish. This is the last of the tables required for surveys.

Copy link
Contributor

@nkiruka nkiruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@caleybrock caleybrock merged commit 613e490 into staging Jun 19, 2018
@caleybrock caleybrock deleted the surveys-mc branch June 19, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants