Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated before_filter callback to before_action #23176

Merged
merged 1 commit into from Jun 19, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Jun 19, 2018

This is failing cronjobs and logging errors to honeybadger:

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from <class:AssessmentsController> at /home/ubuntu/production/dashboard/app/controllers/api/v1/assessments_controller.rb:4)

Errors:
https://app.honeybadger.io/projects/45435/faults/38296603
https://app.honeybadger.io/projects/45435/faults/33614384
https://app.honeybadger.io/projects/45435/faults/38301828
https://app.honeybadger.io/projects/45435/faults/33060312
https://app.honeybadger.io/projects/45435/faults/33058635

Copy link
Contributor

@caleybrock caleybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@aoby aoby merged commit 6a4a93b into staging Jun 19, 2018
@aoby aoby deleted the before-filter-to-before-action branch June 19, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants