Fix Slack command /set-last-dtt-green #23181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralizes logic for marking a DTT red or green to ensure that our DOTD script, slack command, and auto-green logic all do the same thing.
maddiedierker
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted in my dev-of-the-day log yesterday:
Upon investigation today I learned that it would have updated the deploy-status topic if I'd passed an additional parameter, but this is unintuitive and out of sync with our current process.
Here I've removed that parameter, and centralized the logic for marking a DTT green/red so that our DOTD script, Slack slash command, and auto-green logic all run the same set of steps when recording a DTT result.