Assessments Tab: Fix filter bug #23197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| isCorrect: answer.status === 'correct', | ||
| }; | ||
| }) | ||
| studentResponses: studentAssessment.level_results.filter(answer => answer.status !== "free_response") |
There was a problem hiding this comment.
could "free_response" be a constant somewhere?
There was a problem hiding this comment.
Great thought - going to follow up with another PR because there are about 8 places I need to update.
maddiedierker
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were filtering out the free responses for the question structure, but not the student answers so the tables were wrong.
I also updated the tests to catch this case.
Before
After
