Location variables #23204
Merged
Location variables #23204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
reviewed
Jun 20, 2018
| [Blockly.BlockValueType.LOCATION]: [block.getTitleValue(inputConfig.name)], | ||
| }; | ||
| }; | ||
| block.renameVar = function (oldName, newName) { |
There was a problem hiding this comment.
Can some of these inherit from Blockly.Blocks.variables_get?
joshlory
reviewed
Jun 20, 2018
| "args": [ | ||
| { | ||
| "name": "VAR", | ||
| "assignment": true, |
There was a problem hiding this comment.
Nit: Tempting to make this a separate field instead of part of "args", but it makes sense that these get populated from the block inputs, in order. If we could start over, maybe these would be called "fields" instead of "args"?
|
How does a level builder add the "Locations" custom category? Do we need to add an entry to the list in PR #23198? |
|
You may also want the That said, we prob don't care about renaming vars in the preview Block Space. |
joshlory
approved these changes
Jun 20, 2018
balderdash
force-pushed
the
location-variables
branch
from
222c048
to
62be0b1
Compare
balderdash
force-pushed
the
location-variables
branch
from
62be0b1
to
13892da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.