Assessments Tab: loading states #23336
Conversation
| <div> | ||
| <div style={{...h3Style, ...styles.header}}> | ||
| {i18n.selectAssessment()} | ||
| {!isLoading && |
There was a problem hiding this comment.
Why not combine these into 1 !isLoading block?
There was a problem hiding this comment.
It does look a little strange because they seem right next to each other. Styling requires the selectors to be together in one div, which means a single selector and the tables can't actually be in one element :( I think it'll be more obvious once we add more controls to the selector area.
| {i18n.selectAssessment()} | ||
| {!isLoading && | ||
| <div> | ||
| {/* Assessments */} |
There was a problem hiding this comment.
Whoa! I didn't know you could include comments like that in the return of a render!
| {/* Assessments */} | ||
| <MCAssessmentsOverviewContainer /> | ||
| <StudentsMCSummaryContainer /> | ||
| <MultipleChoiceByStudentContainer /> |
There was a problem hiding this comment.
Just because I'm curious: Why do some of the components have MultipleChoice and some abbreviate to MC?
There was a problem hiding this comment.
We might want to consider abbreviating all of them for consistency - but the MC ones got abbreviated because the component names seemed very over the top length wise.
Summary
Gif