Manage linked accounts UI #23355
Merged
Manage linked accounts UI #23355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Jun 27, 2018
| import ReactDOM from 'react-dom'; | ||
| import ManageLinkedAccounts from './ManageLinkedAccounts'; | ||
|
|
||
| export default class ManageLinkedAccountsController { |
There was a problem hiding this comment.
One wonders if we need this layer at all... but I guess we won't know until we've actually added behaviors.
There was a problem hiding this comment.
yeah, i'm thinking this will end up managing the overall state (which providers you're connected to, what should happen when you try to connect/disconnect from each provider, etc), but that might end up not being true
There was a problem hiding this comment.
woops, i wasn't paying attention and was referring to something else ^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
ManageLinkedAccountscomponent, currently with hard-coded emails and emptyonClickhandlers for each oauth provider.Examples
When you hover over a disabled "disconnect" button:
Note: I ended up not displaying the FontAwesome icons for each provider because the Microsoft logo wasn't available (maybe due to the version we are on? i didn't look into it much), but I can look into that once we've got more functionality finished for this feature.