Rename primary_authentication_option to primary_contact_info #23387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_id Also updates the association on User, but then introduces alias getter and setter methods for the old name to avoid breaking existing code. I'm going to run tests against this commit on its own first.
|
The first commit, with the aliased accessors for the old name, passed on Circle. I feel pretty good about that approach now. Pushing additional changes... |
maddiedierker
approved these changes
Jun 28, 2018
dashboard/app/models/user.rb
Outdated
| # TEMPORARY: Remove these aliases | ||
| # | ||
|
|
||
| def primary_authentication_option |
There was a problem hiding this comment.
Note, this can be much more condensed with alias_attribute
alias_attribute :primary_authentication_option, :primary_contact_info…hentication-option-2
|
Discussing potential impact of the column rename on the users table (in particular, odds of causing downtime) in Slack: https://codedotorg.slack.com/archives/C03CK49G9/p1530202891000427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second take on #23231 after we made lots and lots of changes in staging out from under that PR.
The first change is that I've started fresh from a more recent point on
stagingso I'm updating more of our recent work. The second change is that I've leaving in aliases for the old column/association name, to avoid breaking other PRs we have open. Then later we can do the fairly safe change of finishing the rename and removing those alias methods.