Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded grunt tasks #23452

Merged
merged 1 commit into from Jul 2, 2018
Merged

Remove unneeded grunt tasks #23452

merged 1 commit into from Jul 2, 2018

Conversation

islemaster
Copy link
Contributor

Removes three grunt-specific packages that we don't need anymore.

  • grunt-open is unused.
  • grunt-parallel is unused.
  • grunt-strip-code was only being used to remove code in two places, and is redundant with our IN_UNIT_TEST constant defined by the Webpack define plugin and tree shaking.

@islemaster islemaster requested a review from Hamms July 2, 2018 16:35
Hamms
Hamms approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@islemaster islemaster merged commit e9d2084 into staging Jul 2, 2018
@islemaster islemaster deleted the remove-unneeded-grunt-tasks branch July 2, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@islemaster @Hamms