Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessments Tab: show survey names in dropdown #23481

Merged
merged 4 commits into from Jul 3, 2018

Conversation

caleybrock
Copy link
Contributor

pair programmed with @nkiruka

Before surveys would only appear as an option in the dropdown if at least 5 students already submitted a survey.

This PR makes it so that the dropdown is consistent regardless of submissions.

Updates were required to redux and the model. Both changes are tested.

screen shot 2018-07-02 at 4 21 48 pm

Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caleybrock caleybrock merged commit 9a743f4 into staging Jul 3, 2018
@caleybrock caleybrock deleted the show-surveys-in-dropdown branch July 3, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants