Remove craft "while block ahead" #23502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was created during the development of the tutorial, but never shipped in the final HoC tutorial.
Hamms
approved these changes
Jul 5, 2018
|
Good question! None that I know of offhand, but we should keep an eye out 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this never shipped in a published tutorial, we were hesitant to remove it in case any test users had the block saved in their level solution. Now that we handle unknown blocks more gracefully I think it's time to deprecate this block!
This also lets us remove an untested code path for
WhileCommandin the engine.