Connect ManageLinkedAccounts to server data #23505
Conversation
| }; | ||
|
|
||
| onFailure = (error) => { | ||
| // TODO: (madelynkasula) display error to user |
There was a problem hiding this comment.
i'm not really sure how we want to surface a DELETE /users/auth/:id/disconnect to users. some options:
- display a notification above the table (via our React notification component)
- display the error message next to the "Connect/Disconnect" button
- other thoughts/options?
There was a problem hiding this comment.
I think either of those would work. We don't have an intermediate state yet, but I'd be most likely to put the error wherever that 'in progress' status lives - maybe on the button itself, even. Our desired outcome is probably for the user to click the disconnect button again, in case it's an intermittent issue.
| navigateToHref(`/users/auth/${provider}/connect`); | ||
| }; | ||
|
|
||
| disconnect = (authOptionId) => { |
There was a problem hiding this comment.
I feel like this method could be a lot simpler, either using fetch or async/await or both.
| @@ -209,7 +209,8 @@ | |||
| userAge: current_user.age, | |||
| userType: current_user.user_type, | |||
| isOauth: current_user.oauth?, | |||
| isPasswordRequired: current_user.encrypted_password.present? | |||
| isPasswordRequired: current_user.encrypted_password.present?, | |||
| authenticationOptions: current_user.authentication_options, | |||
There was a problem hiding this comment.
Would this potentially render OAuth tokens on the client? Maybe we should find a way to only include the info we need from each authentication option.
|
@islemaster i just added a |
This PR connects
ManageLinkedAccountsto actual data from the server!What it does
ManageLinkedAccountswith existing oauth authentication optionsFollow-up Work
DELETE /users/auth/:id/disconnect(currently just logging to the console)