Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add 2018 courses to k5_course? helper"" #23513

Merged
merged 8 commits into from Jul 12, 2018

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 4, 2018

Reverts #23510

@Hamms Hamms force-pushed the revert-23510-revert-23465-enable-tts-2018 branch from 2e356ce to 209a1f4 Compare July 5, 2018 19:46
@Hamms Hamms requested a review from davidsbailey July 5, 2018 19:49
@davidsbailey
Copy link
Member

This looks like it should work. If you want to be sure to catch any dashboard / pegasus isolation issues, you could run dashboard locally with dashboard_enable_pegasus: false and then run pegasus separately.

Out of curiosity, in which kind of tests (unit tests or ui tests) was pegasus code previously able to access Script?

@Hamms
Copy link
Contributor Author

Hamms commented Jul 5, 2018

Oh, that's good to know! I wasn't aware it was that easy to run in isolation.

I don't think pegasus was able to access Script in any test environment; in fact, I actually wrote the test first, before moving the functionality to ScriptConstant and verified that it failed with the NameError. The context in which pegasus was able to access Script was just running the server locally, which gave me false confidence that it would just work.

@davidsbailey
Copy link
Member

makes sense, thanks for explaining. to run separately/locally, you may also have to set pegasus_port: 3001

@Hamms Hamms force-pushed the revert-23510-revert-23465-enable-tts-2018 branch from 0db1f10 to 1c17410 Compare July 5, 2018 22:14
@Hamms Hamms force-pushed the revert-23510-revert-23465-enable-tts-2018 branch from 1c17410 to bf47903 Compare July 9, 2018 21:16
@Hamms Hamms merged commit 7b2080a into staging Jul 12, 2018
@Hamms Hamms deleted the revert-23510-revert-23465-enable-tts-2018 branch July 12, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants