Assessments: Style free responses assessments question #23515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or hide full question link
…m:code-dot-org/code-dot-org into style-free-responses-assessments-question
caleybrock
reviewed
Jul 5, 2018
| @@ -24,7 +34,11 @@ class FreeResponseBySurveyQuestionContainer extends Component { | |||
| <h2>{i18n.studentFreeResponseAnswers()}</h2> | |||
| {freeResponsesByQuestion.map((question, index) => ( | |||
| <div key={index}> | |||
| <h3>{`${question.questionNumber}. ${question.questionText}`}</h3> | |||
| <div style={styles.text}> | |||
| <span>{`${question.questionNumber}. ${question.questionText}`.slice(0, QUESTION_CHARACTER_LIMIT)}</span> | |||
There was a problem hiding this comment.
I think it's cleaner to write this like this because we care mostly about slicing the question text:
{`${question.questionNumber}. ${question.questionText.slice(0, QUESTION_CHARACTER_LIMIT)}`}
| <h3>{`${question.questionNumber}. ${question.questionText}`}</h3> | ||
| <div style={styles.text}> | ||
| <span>{`${question.questionNumber}. ${question.questionText}`.slice(0, QUESTION_CHARACTER_LIMIT)}</span> | ||
| {((question.questionText.length >= QUESTION_CHARACTER_LIMIT)) |
There was a problem hiding this comment.
I think it's a bit cleaner to write this line like this:
{ question.questionText.length >= QUESTION_CHARACTER_LIMIT &&
<a href="#"><span>{i18n.seeFullQuestion()}</span></a>
}
maddiedierker
approved these changes
Jul 5, 2018
…esponse question exceed character limit
caleybrock
suggested changes
Jul 6, 2018
caleybrock
approved these changes
Jul 6, 2018
|
Hmmm something went wrong with this merge conflict |
nkiruka
force-pushed
the
style-free-responses-assessments-question
branch
from
24f46db
to
df655fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The free response assessments table has question text above the table. When the question exceeds the number of characters to fit within two lines, the question is truncated and a link to view the full question is visible (see full question).
If the question does not exceed the question character limit, the link to view the full question is hidden.
Screen shot
Screen shot