Revert "Revert "Assessments: Add color to multiple choice assessments table"" #23553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const opacity = calculateOpacity(percentValue); | ||
|
|
||
| const backgroundCSS = (isCorrectAnswer || isSurvey) ? {backgroundColor: `rgba(159, 212, 159, ${opacity})`} : |
There was a problem hiding this comment.
you could pull the logic on lines 42-45 into a function like this:
getBackgroundColor = (percentValue) => {
const {isCorrectAnswer, isSurvey} = this.props;
const opacity = calculateOpacity(percentValue);
return (isCorrectAnswer || isSurvey) ? `rgba(159, 212, 159, ${opacity})` : `rgba(255, 99, 71, ${opacity})`;
};
then plug that into: const backgroundCSS = {backgroundColor: getBackgroundColor(percentValue}; to clarify the logic here a little. not a blocker, but something to consider
There was a problem hiding this comment.
Great idea, will follow up.
maddiedierker
approved these changes
Jul 6, 2018
caleybrock
deleted the
revert-23552-revert-23532-add-color-assessments-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23552
Summary
For summary see original PR: #23532
Additionally this PR fixes some bugs detailed below.
Here's the main work from that PR:
Pair programmed: Caley / @nkiruka
Bugs before
Bugs after